Add \ for Sym/Tri/Bi/Diagonal and support non-commutative numbers #39701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
reviewed
Feb 17, 2021
Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
|
Are these rules correct also in the non-commutative case? I see we're using this "flip the order" pattern frequently... |
|
I agree it doesn't look good for non-commutativit, but this is true also for |
|
Do you know if there's a non-commutative type |
|
We have a |
|
I think |
dlfivefifty
changed the title
|
OK I added the overload for Diagonal too |
|
I believe the test failure is not related. |
dkarrasch
approved these changes
Feb 21, 2021
|
Let's run CI again and then merge. |
|
Only failure is a timeout, but way after the LinearAlgebra tests. |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…liaLang#39701) Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
…liaLang#39701) Co-authored-by: Daniel Karrasch <daniel.karrasch@posteo.de>
This was referenced May 13, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.