Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jl_egal_types: don't reject equivalence just for gensyms #39778

Merged
merged 1 commit into from
Feb 25, 2021
Merged

jl_egal_types: don't reject equivalence just for gensyms #39778

merged 1 commit into from
Feb 25, 2021
+17 −1

Commits on Feb 23, 2021

  1. equiv_typedef: don't reject equivalence just for gensyms 

    This fixes the following:

```
julia> struct Symmetric{T,S<:AbstractMatrix{<:T}} <: AbstractMatrix{T}
           data::S
           uplo::Char
       end

julia> struct Symmetric{T,S<:AbstractMatrix{<:T}} <: AbstractMatrix{T}
           data::S
           uplo::Char
       end
ERROR: invalid redefinition of constant Symmetric
```

`Core._equiv_typedef` returns false which ends up triggering the error.
    @timholy
    timholy committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    af8ff73 View commit details
    Browse the repository at this point in the history