Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinearAlgebra._generic_matmul! : Avoid division by zero for tile_size. #39790

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 22, 2021

If the size of all involved types is zero, use the maximum tile size, and
follow the same code path for simplicity.

Fixes #39362.

If the size of all involved types is zero, use the maximum tile size, and
follow the same code path for simplicity.

Fixes 39362.
@ViralBShah
Copy link
Member

ViralBShah commented Feb 22, 2021

This PR should be ok to merge (it doesn't change any of the files that #39455 is modifying)

@ghost ghost marked this pull request as ready for review February 23, 2021 08:35
@dkarrasch dkarrasch added bugfix This change fixes an existing bug linear algebra Linear algebra labels Feb 23, 2021
@dkarrasch dkarrasch merged commit eca3e86 into JuliaLang:master Feb 26, 2021
@simeonschaub simeonschaub added the backport 1.6 Change should be backported to release-1.6 label Feb 26, 2021
KristofferC pushed a commit that referenced this pull request Mar 2, 2021
@KristofferC KristofferC mentioned this pull request Mar 2, 2021
52 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Mar 14, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array{Missing} breaks matrix multiplication in some cases
5 participants