fix #39804, ABI handling of structs with String references #39821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
compiler:codegen
vtjnash
reviewed
Feb 25, 2021
| @@ -151,7 +151,7 @@ void classifyType(Classification& accum, jl_datatype_t *dt, uint64_t offset) con | |||
| size_t i; | |||
| for (i = 0; i < jl_datatype_nfields(dt); ++i) { | |||
| jl_value_t *ty = jl_field_type(dt, i); | |||
| if (!jl_is_datatype(ty) || ((jl_datatype_t*)ty)->layout == NULL || jl_is_array_type(ty)) | |||
| if (jl_field_isptr(dt, i)) | |||
There was a problem hiding this comment.
I don't think ->layout is necessarily defined. I'm unsure the best way to match _julia_struct_to_llvm here, as it seems many other abi files might similarly be trying to access it.
There was a problem hiding this comment.
I updated a couple other cases; see what you think.
vtjnash
approved these changes
Feb 25, 2021
JeffBezanson
force-pushed
the
jb/fix39804
branch
from
ccb517d
to
571064a
Compare
KristofferC
pushed a commit
that referenced
this pull request
Mar 2, 2021
This was referenced Mar 21, 2021
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks to me like the other ABIs don't need this, but somebody else should check to be sure.
Unfortunately does not help #28669.
fix #39804