Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugReporting] pass ARGS through properly #39839

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Conversation

staticfloat
Copy link
Sponsor Member

When calling make_interactive_report(), we really need to pass in
ARGS as well, otherwise it always starts an interactive session.

This commit, in combination with -- allows the user to run an rr
session while still passing arguments to the child julia process via:

julia --bug-report=rr -- --project test/runtests.jl

When calling `make_interactive_report()`, we really need to pass in
`ARGS` as well, otherwise it always starts an interactive session.

This commit, in combination with `--` allows the user to run an `rr`
session while still passing arguments to the child `julia` process via:

```
julia --bug-report=rr -- --project test/runtests.jl
```
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :)

@Keno Keno added the backport 1.6 Change should be backported to release-1.6 label Mar 2, 2021
@Keno Keno merged commit 5e7aaa6 into master Mar 2, 2021
@Keno Keno deleted the sf/bug_report_pass_args branch March 2, 2021 02:22
KristofferC pushed a commit that referenced this pull request Mar 2, 2021
When calling `make_interactive_report()`, we really need to pass in
`ARGS` as well, otherwise it always starts an interactive session.

This commit, in combination with `--` allows the user to run an `rr`
session while still passing arguments to the child `julia` process via:

```
julia --bug-report=rr -- --project test/runtests.jl
```

(cherry picked from commit 5e7aaa6)
@KristofferC KristofferC mentioned this pull request Mar 2, 2021
52 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Mar 14, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
When calling `make_interactive_report()`, we really need to pass in
`ARGS` as well, otherwise it always starts an interactive session.

This commit, in combination with `--` allows the user to run an `rr`
session while still passing arguments to the child `julia` process via:

```
julia --bug-report=rr -- --project test/runtests.jl
```
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
When calling `make_interactive_report()`, we really need to pass in
`ARGS` as well, otherwise it always starts an interactive session.

This commit, in combination with `--` allows the user to run an `rr`
session while still passing arguments to the child `julia` process via:

```
julia --bug-report=rr -- --project test/runtests.jl
```
staticfloat added a commit that referenced this pull request Dec 23, 2022
When calling `make_interactive_report()`, we really need to pass in
`ARGS` as well, otherwise it always starts an interactive session.

This commit, in combination with `--` allows the user to run an `rr`
session while still passing arguments to the child `julia` process via:

```
julia --bug-report=rr -- --project test/runtests.jl
```

(cherry picked from commit 5e7aaa6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants