Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinearAlgebra: Add test "matrix x matrix with negative stride". #39849

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

ghost
Copy link

@ghost ghost commented Feb 27, 2021

(Made while looking at #39836, which is matrix x vector.
Matrix x matrix with negative stride is fine as it is, because
it uses the Julia implementation of matrix multiplication.)

@ViralBShah ViralBShah added linear algebra Linear algebra test This change adds or pertains to unit tests labels Feb 27, 2021
@ghost ghost force-pushed the db/test-mm-neg-stride branch from fc16272 to 065dfa2 Compare February 27, 2021 20:32
test/cmdlineargs.jl Outdated Show resolved Hide resolved
@ghost ghost force-pushed the db/test-mm-neg-stride branch 2 times, most recently from c08a9a0 to 630e1a1 Compare February 27, 2021 23:48
@ghost
Copy link
Author

ghost commented Feb 28, 2021

(back to just one commit which adds a test)

@ghost ghost force-pushed the db/test-mm-neg-stride branch from 630e1a1 to 04ca2a9 Compare February 28, 2021 08:51
(Made while looking at JuliaLang#39836, which is matrix x vector.
Matrix x matrix with negative stride is fine as it is, because
it uses the Julia implementation of matrix multiplication.)
@ghost ghost force-pushed the db/test-mm-neg-stride branch from 04ca2a9 to c469060 Compare February 28, 2021 09:29
@simeonschaub simeonschaub merged commit 621ee2a into JuliaLang:master Mar 1, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
…aLang#39849)

(Made while looking at JuliaLang#39836, which is matrix x vector.
Matrix x matrix with negative stride is fine as it is, because
it uses the Julia implementation of matrix multiplication.)
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
…aLang#39849)

(Made while looking at JuliaLang#39836, which is matrix x vector.
Matrix x matrix with negative stride is fine as it is, because
it uses the Julia implementation of matrix multiplication.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants