-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore StackOverflow error message for repeated frames #39930
Merged
JeffBezanson
merged 1 commit into
master
from
jb/NHDaly-nhd-StackOverflow-error-message-repeats-n-times
Mar 11, 2021
Merged
Restore StackOverflow error message for repeated frames #39930
JeffBezanson
merged 1 commit into
master
from
jb/NHDaly-nhd-StackOverflow-error-message-repeats-n-times
Mar 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
backport 1.6
Change should be backported to release-1.6
bugfix
This change fixes an existing bug
error messages
Better, more actionable error messages
labels
Mar 5, 2021
Sacha0
approved these changes
Mar 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ! :)
Fixes backtrace printing to display the number of times a frame is repeated, if there is a frame that's duplicated several times. ```julia julia> function foo() foo() end foo (generic function with 1 method) julia> foo() ERROR: StackOverflowError: Stacktrace: [1] foo() (repeats 79984 times) @ Main ./REPL[16]:1 ``` Fixes #37587.
JeffBezanson
force-pushed
the
jb/NHDaly-nhd-StackOverflow-error-message-repeats-n-times
branch
from
March 9, 2021 20:34
71f28ad
to
8cc8d30
Compare
JeffBezanson
deleted the
jb/NHDaly-nhd-StackOverflow-error-message-repeats-n-times
branch
March 11, 2021 18:20
❤️ Thank you Jeff! Sorry for my delay; thanks for carrying this across the finish line 👍 👍 |
KristofferC
pushed a commit
that referenced
this pull request
Mar 14, 2021
Fixes backtrace printing to display the number of times a frame is repeated, if there is a frame that's duplicated several times. ```julia julia> function foo() foo() end foo (generic function with 1 method) julia> foo() ERROR: StackOverflowError: Stacktrace: [1] foo() (repeats 79984 times) @ Main ./REPL[16]:1 ``` Fixes #37587. Co-authored-by: Nathan Daly <nhdaly@gmail.com> (cherry picked from commit 3276c11)
14 tasks
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
) Fixes backtrace printing to display the number of times a frame is repeated, if there is a frame that's duplicated several times. ```julia julia> function foo() foo() end foo (generic function with 1 method) julia> foo() ERROR: StackOverflowError: Stacktrace: [1] foo() (repeats 79984 times) @ Main ./REPL[16]:1 ``` Fixes JuliaLang#37587. Co-authored-by: Nathan Daly <nhdaly@gmail.com>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
) Fixes backtrace printing to display the number of times a frame is repeated, if there is a frame that's duplicated several times. ```julia julia> function foo() foo() end foo (generic function with 1 method) julia> foo() ERROR: StackOverflowError: Stacktrace: [1] foo() (repeats 79984 times) @ Main ./REPL[16]:1 ``` Fixes JuliaLang#37587. Co-authored-by: Nathan Daly <nhdaly@gmail.com>
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Fixes backtrace printing to display the number of times a frame is repeated, if there is a frame that's duplicated several times. ```julia julia> function foo() foo() end foo (generic function with 1 method) julia> foo() ERROR: StackOverflowError: Stacktrace: [1] foo() (repeats 79984 times) @ Main ./REPL[16]:1 ``` Fixes #37587. Co-authored-by: Nathan Daly <nhdaly@gmail.com> (cherry picked from commit 3276c11)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39378, with tests enabled on linux x86_64.