Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore StackOverflow error message for repeated frames #39930

Merged

Conversation

JeffBezanson
Copy link
Member

#39378, with tests enabled on linux x86_64.

@JeffBezanson JeffBezanson added backport 1.6 Change should be backported to release-1.6 bugfix This change fixes an existing bug error messages Better, more actionable error messages labels Mar 5, 2021
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ! :)

Fixes backtrace printing to display the number of times a frame is
repeated, if there is a frame that's duplicated several times.

```julia
julia> function foo() foo() end
foo (generic function with 1 method)

julia> foo()
ERROR: StackOverflowError:
Stacktrace:
 [1] foo() (repeats 79984 times)
   @ Main ./REPL[16]:1
```

Fixes #37587.
@JeffBezanson JeffBezanson force-pushed the jb/NHDaly-nhd-StackOverflow-error-message-repeats-n-times branch from 71f28ad to 8cc8d30 Compare March 9, 2021 20:34
@JeffBezanson JeffBezanson reopened this Mar 10, 2021
@JeffBezanson JeffBezanson merged commit 3276c11 into master Mar 11, 2021
@JeffBezanson JeffBezanson deleted the jb/NHDaly-nhd-StackOverflow-error-message-repeats-n-times branch March 11, 2021 18:20
@NHDaly
Copy link
Member

NHDaly commented Mar 11, 2021

❤️ Thank you Jeff! Sorry for my delay; thanks for carrying this across the finish line 👍 👍

KristofferC pushed a commit that referenced this pull request Mar 14, 2021
Fixes backtrace printing to display the number of times a frame is
repeated, if there is a frame that's duplicated several times.

```julia
julia> function foo() foo() end
foo (generic function with 1 method)

julia> foo()
ERROR: StackOverflowError:
Stacktrace:
 [1] foo() (repeats 79984 times)
   @ Main ./REPL[16]:1
```

Fixes #37587.

Co-authored-by: Nathan Daly <nhdaly@gmail.com>
(cherry picked from commit 3276c11)
@KristofferC KristofferC mentioned this pull request Mar 14, 2021
14 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Mar 23, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
)

Fixes backtrace printing to display the number of times a frame is
repeated, if there is a frame that's duplicated several times.

```julia
julia> function foo() foo() end
foo (generic function with 1 method)

julia> foo()
ERROR: StackOverflowError:
Stacktrace:
 [1] foo() (repeats 79984 times)
   @ Main ./REPL[16]:1
```

Fixes JuliaLang#37587.

Co-authored-by: Nathan Daly <nhdaly@gmail.com>
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
)

Fixes backtrace printing to display the number of times a frame is
repeated, if there is a frame that's duplicated several times.

```julia
julia> function foo() foo() end
foo (generic function with 1 method)

julia> foo()
ERROR: StackOverflowError:
Stacktrace:
 [1] foo() (repeats 79984 times)
   @ Main ./REPL[16]:1
```

Fixes JuliaLang#37587.

Co-authored-by: Nathan Daly <nhdaly@gmail.com>
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Fixes backtrace printing to display the number of times a frame is
repeated, if there is a frame that's duplicated several times.

```julia
julia> function foo() foo() end
foo (generic function with 1 method)

julia> foo()
ERROR: StackOverflowError:
Stacktrace:
 [1] foo() (repeats 79984 times)
   @ Main ./REPL[16]:1
```

Fixes #37587.

Co-authored-by: Nathan Daly <nhdaly@gmail.com>
(cherry picked from commit 3276c11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug error messages Better, more actionable error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants