Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate unsafe_length for length #40382

Merged
merged 4 commits into from
Jul 2, 2021
Merged

deprecate unsafe_length for length #40382

merged 4 commits into from
Jul 2, 2021

Commits on Jun 9, 2021

  1. deprecate unsafe_length for length

    This seems to be a fairly arbitrary case for throwing exceptions, when
    the user might often use this value in arithmetic afterwards, which is
    not checked. It leads to awkward complexity in the API however, where it
    may be unclear which function to reach for, with no particular
    justification for why a particular usage is "safe". And it inhibits
    optimization and performance due to the additional checks and error
    cases (and is not even entirely type-stable).
    vtjnash committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    1424822 View commit details
    Browse the repository at this point in the history
  2. fix method discrepencies

    vtjnash committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    96a1e5f View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Configuration menu
    Copy the full SHA
    7bb6ee1 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Configuration menu
    Copy the full SHA
    2db3b9c View commit details
    Browse the repository at this point in the history