Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate error when using bad generator in Dict #40445

Closed
wants to merge 1 commit into from
Closed

Fix duplicate error when using bad generator in Dict #40445

wants to merge 1 commit into from

Conversation

omus
Copy link
Member

@omus omus commented Apr 12, 2021

Fixes: #33147

@omus omus added error handling Handling of exceptions by Julia or the user bugfix This change fixes an existing bug labels Apr 12, 2021
@omus omus mentioned this pull request Apr 12, 2021
Merged
@JeffBezanson
Copy link
Member

Oof, this error path is so ugly. I wonder if we could remove all the try blocks, and instead check for this case by examining the stack during error printing. That might be more accurate as well, better distinguishing errors actually caused by invalid elements.

@StefanKarpinski
Copy link
Member

Bump.

@lmshk lmshk mentioned this pull request Sep 25, 2022
Closed
vtjnash added a commit that referenced this pull request Feb 1, 2024
@omus @vtjnash
Fix duplicate error when using generator in Dict
49f08cd 
Fixes: #33147
Replaces/Closes: #40445
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
vtjnash added a commit that referenced this pull request Feb 1, 2024
@omus @vtjnash
Fix duplicate error when using generator in Dict
b7b4d0a 
Fixes: #33147
Replaces/Closes: #40445
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@vtjnash vtjnash mentioned this pull request Feb 1, 2024
Merged
@vtjnash vtjnash closed this in 5547305 Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug error handling Handling of exceptions by Julia or the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dict construction calls generator side effects twice on failure
3 participants
@omus @JeffBezanson @StefanKarpinski