Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable new Float16 methods for sinh and cbrt #40534

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Apr 19, 2021

From #39432 and #39441, these were still using their old definition due
to method overwriting.

@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Apr 19, 2021
From #39432 and #39441, these were still using their old definition due
to method overwriting.
@vtjnash vtjnash force-pushed the jn/39432-and-39441 branch from c2cca0a to 5a21363 Compare April 19, 2021 21:21
@oscardssmith
Copy link
Member

well that's embarrassing.

@oscardssmith oscardssmith self-requested a review April 19, 2021 21:23
@oscardssmith oscardssmith merged commit 5784cd3 into master Apr 20, 2021
@oscardssmith oscardssmith deleted the jn/39432-and-39441 branch April 20, 2021 04:17
@simeonschaub simeonschaub removed the merge me PR is reviewed. Merge when all tests are passing label Apr 28, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
From JuliaLang#39432 and JuliaLang#39441, these were still using their old definition due
to method overwriting.
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
From JuliaLang#39432 and JuliaLang#39441, these were still using their old definition due
to method overwriting.
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
From JuliaLang#39432 and JuliaLang#39441, these were still using their old definition due
to method overwriting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants