Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not trim trailing zeros of integral part #40755

Merged
merged 1 commit into from
May 11, 2021
Merged

do not trim trailing zeros of integral part #40755

merged 1 commit into from
May 11, 2021

Conversation

bicycle1885
Copy link
Member

@bicycle1885 bicycle1885 commented May 9, 2021 •
edited
Loading

Currently, setting trimtrailingzeros = true of Ryu.writefixed may trim trailing zeros of integral part if precision = 0, which is surprising because it changes the scale of the value:

using Base: Ryu

@show Ryu.writefixed(1.25e+5, 0, false, false, false, UInt8('.'), true)
@show Ryu.writefixed(1.25e+5, 1, false, false, false, UInt8('.'), true)
@show Ryu.writefixed(1.25e+5, 2, false, false, false, UInt8('.'), true)
Ryu.writefixed(125000.0, 0, false, false, false, UInt8('.'), true) = "125"
Ryu.writefixed(125000.0, 1, false, false, false, UInt8('.'), true) = "125000"
Ryu.writefixed(125000.0, 2, false, false, false, UInt8('.'), true) = "125000"

This PR fixes the problem so that only trailing zeros of fractional part are trimmed. I think this change is not breaking because Ryu is not a part of the official API.

@bicycle1885 bicycle1885 requested a review from quinnj May 9, 2021 02:51
@bicycle1885 bicycle1885 mentioned this pull request May 10, 2021
Merged
quinnj
quinnj approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quinnj quinnj merged commit 79b8af2 into JuliaLang:master May 11, 2021
@bicycle1885 bicycle1885 deleted the ryu-trimzeros branch May 11, 2021 03:55
@bicycle1885 bicycle1885 added the backport 1.6 Change should be backported to release-1.6 label May 11, 2021
@KristofferC KristofferC mentioned this pull request May 11, 2021
Merged
45 tasks
vtjnash
vtjnash reviewed May 11, 2021
View reviewed changes
test/ryu.jl
Comment on lines +552 to +554
@show Ryu.writefixed(1.25e+5, 0, false, false, false, UInt8('.'), true) == "125000"
@show Ryu.writefixed(1.25e+5, 1, false, false, false, UInt8('.'), true) == "125000"
@show Ryu.writefixed(1.25e+5, 2, false, false, false, UInt8('.'), true) == "125000"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/@show/@test/ 😂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump (@quinnj, as reviewer)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#40938

@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bicycle1885 @vtjnash @quinnj @KristofferC