-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up a few code owners #40925
Set up a few code owners #40925
Conversation
Any committer should feel free to add themselves as code owners for their areas of expertise - just make a PR to edit the Here's the syntax for the |
Is it possible to create teams of people, and then delegate parts of the codebase to the different teams in the CODEOWNERS? |
Definitely! |
/src/ @JuliaLang/compiler | ||
/stdlib/LinearAlgebra/ @JuliaLang/linearalgebra | ||
/stdlib/libblastrampoline_jll/ @staticfloat | ||
/test/ @JuliaLang/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this is all that useful since almost any PR adds some tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thought was to see how useful this feature is and get it calibrated.
/.github/workflows/ @JuliaLang/github-actions | ||
/.github/ @JuliaLang/github-actions | ||
/.buildkite/ @JuliaLang/github-actions | ||
/src/ @JuliaLang/compiler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this should be a bit more fine-grained? I'd be comfortable reviewing frontend changes, but likely won't be able to contribute much if it touches codegen or parts of the C API. Also should perhaps add base/compiler
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of my suggestion in #40925 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe. Although especially for some files in base
this might be a bit of a noisy measure and it might be better for folks to be able to opt in manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't people's global preferences on notifications anyways override this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant noisy here mostly in terms of that it might be rather arbitrary who is assigned to a file or not, but perhaps that's something we should just try and then see how it goes.
Maybe we should generate this file automatically based on the interesection set of |
Also, note that later lines in the CODEOWNERS file override earlier lines. So e.g. if you have this: * @foo
*.js @bar If you have a PR that only modifies |
I think this would work well. And we can always manually edit the result. So e.g. someone can choose to remove themselves from the file if they don't like getting the pings. |
For now, we've pared down a bit: #40929 |
Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com> (cherry picked from commit 3bbe22e)
Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com> (cherry picked from commit 3bbe22e)
Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com> (cherry picked from commit 3bbe22e)
Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com> (cherry picked from commit 3bbe22e)
No description provided.