Indexing OneTo with IdentityUnitRange preserves axes #40997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnychen94
approved these changes
May 29, 2021
There was a problem hiding this comment.
I understand that this cooperates with #40660 and OffsetArrays for more consistent result:
using OffsetArrays
inds = Base.IdentityUnitRange(2:7);
(1:7)[inds] |> axes
# (OffsetArrays.IdOffsetRange(values=2:7, indices=2:7),)
collect(1:7)[inds] |> axes
# (OffsetArrays.IdOffsetRange(values=2:7, indices=2:7),)
# fixes the inconsistency in master
Base.OneTo(7)[inds] |> axes
# master: (Base.OneTo(6),)
# PR: (Base.IdentityUnitRange(2:7),)
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On master:
After this PR: