-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix command literals with trailing backslashes #41041
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
added
bugfix
This change fixes an existing bug
cmd
Relates to calling of external programs
labels
Jun 1, 2021
vtjnash
reviewed
Jun 1, 2021
simeonschaub
added
backport 1.6
Change should be backported to release-1.6
backport 1.7
labels
Jun 9, 2021
45 tasks
51 tasks
This was referenced Jul 7, 2021
Bumping this again. |
63 tasks
simeonschaub
added
the
forget me not
PRs that one wants to make sure aren't forgotten
label
Oct 18, 2021
95 tasks
66 tasks
29 tasks
50 tasks
45 tasks
78 tasks
This was referenced Sep 7, 2022
`` `\\` `` currently throws an error because it is parsed as `@cmd "\\"` due to escaping in the parser and `shell_parse` therefore thinks it's a dangling backslash.
vtjnash
force-pushed
the
sds/unesc_backslash_cmd
branch
from
November 1, 2023 22:04
407f798
to
0662f62
Compare
I tried finishing this PR, but Pkg currently relies on the existing behavior in one place:
The trouble being that |
vtjnash
pushed a commit
that referenced
this pull request
Nov 2, 2023
Similar to how `escape_raw_string` enabled users to reverse the transform done by string literals, this enables users to reverse the transform done by cmd literals by specifying an argument of a '\`'. Refs #41041
vtjnash
added a commit
that referenced
this pull request
Nov 4, 2023
Similar to how `escape_raw_string` enabled users to reverse the transform done by string literals, this enables users to reverse the transform done by cmd literals by specifying an argument of a '\`'. Refs #41041 Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
Superseded by #52001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.6
Change should be backported to release-1.6
bugfix
This change fixes an existing bug
cmd
Relates to calling of external programs
forget me not
PRs that one wants to make sure aren't forgotten
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
`\\`
currently throws an error because it is parsed as@cmd "\\"
due to escaping in the parser and
shell_parse
therefore thinks it's adangling backslash.