Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use textwidth in Printf for %s and %c widths #41085

Merged
merged 3 commits into from
Jun 17, 2021
Merged

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Jun 4, 2021

Closes #41068 (similar to the discussion regarding #38256).

@stevengj stevengj added unicode Related to unicode characters and encodings display and printing Aesthetics and correctness of printed representations of objects. labels Jun 4, 2021
@stevengj stevengj requested a review from quinnj June 4, 2021 14:04
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stevengj
Copy link
Member Author

stevengj commented Jun 7, 2021

@mortenpi, I'm sure what is going on with Documenter.jl, any insights? Explained by #41085 (comment) below.

@stevengj stevengj force-pushed the sgj/printf-textwidth branch from 50a3dd3 to cc8b6bd Compare June 8, 2021 16:20
@stevengj stevengj force-pushed the sgj/printf-textwidth branch from cc8b6bd to 6c47b15 Compare June 9, 2021 13:20
@stevengj
Copy link
Member Author

Hooray, tests are green. Should be good to merge?

@quinnj quinnj merged commit 25efa99 into master Jun 17, 2021
@quinnj quinnj deleted the sgj/printf-textwidth branch June 17, 2021 03:26
@stevengj
Copy link
Member Author

stevengj commented Jan 6, 2022

For some reason, this PR did't make it into the Julia 1.7 release — not sure why? Oh, I guess it was merged right after the feature freeze (June 1, 2021).

stevengj added a commit that referenced this pull request Jan 6, 2022
#41085 was not released in Julia 1.7, and only appears in Julia 1.8.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
JuliaLang#41085 was not released in Julia 1.7, and only appears in Julia 1.8.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
JuliaLang#41085 was not released in Julia 1.7, and only appears in Julia 1.8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
display and printing Aesthetics and correctness of printed representations of objects. unicode Related to unicode characters and encodings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@printf should use textwidth for "%ns" and "%0.ns"
3 participants