hvncat: enable concatenations to return an array of the same kind
#41194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @testset "multidimensional concatenation returns BitArrays" begin | ||
| a = BitVector(ones(5)) | ||
| @test typeof([a ;;; a]) <: BitArray |
There was a problem hiding this comment.
Suggested change
| @test typeof([a ;;; a]) <: BitArray | |
| @test [a ;;; a] isa BitArray |
There was a problem hiding this comment.
It got merged without this suggestion; should I add it to a new PR?
KristofferC
pushed a commit
that referenced
this pull request
Jun 17, 2021
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking down #41143 into smaller pieces.
This PR relies on
similarto return specialty array types when possible, just likehvcatalready does.The several specific
cat_similarmethods cut down allocations.