Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverse search fix #41203

Merged
merged 2 commits into from
Jun 15, 2021
Merged

reverse search fix #41203

merged 2 commits into from
Jun 15, 2021

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Jun 11, 2021 •
edited
Loading

fix #39401, #40244

stevengj
stevengj previously approved these changes Jun 14, 2021
View reviewed changes
stevengj
stevengj reviewed Jun 14, 2021
View reviewed changes
base/strings/search.jl Outdated Show resolved Hide resolved
@stevengj stevengj dismissed their stale review June 14, 2021 14:26

fix is in wrong method

@KristofferC KristofferC added backport 1.6 Change should be backported to release-1.6 bugfix This change fixes an existing bug labels Jun 14, 2021
@Moelf Moelf force-pushed the fix_search_last branch from d984b31 to 6a415a7 Compare June 14, 2021 18:22
@fredrikekre fredrikekre merged commit 88a0560 into JuliaLang:master Jun 15, 2021
KristofferC pushed a commit that referenced this pull request Jun 17, 2021
@Moelf @KristofferC
Fix for reverse search, fixes #39401, fixes #40244(#41203)
aa3a19f 
(cherry picked from commit 88a0560)
@KristofferC KristofferC mentioned this pull request Jun 17, 2021
Merged
20 tasks
KristofferC pushed a commit that referenced this pull request Jun 29, 2021
@Moelf @KristofferC
Fix for reverse search, fixes #39401, fixes #40244(#41203)
e0519e3 
(cherry picked from commit 88a0560)
@KristofferC KristofferC mentioned this pull request Jun 29, 2021
Merged
45 tasks
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@Moelf @johanmon
Fix for reverse search, fixes JuliaLang#39401, fixes JuliaLang#40244(J…
5ba05c6 
…uliaLang#41203)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 12, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@Moelf @staticfloat
Fix for reverse search, fixes #39401, fixes #40244(#41203)
5779df3 
(cherry picked from commit 88a0560)
@Moelf Moelf deleted the fix_search_last branch May 25, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Random errors when searching REPL's history with "Ctrl-r"
4 participants
@Moelf @stevengj @KristofferC @fredrikekre