fix preference loading for non string value #41294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would indeed be good to have some docs / tests for this (ref #38459). Otherwise, it is hard to not introduce regressions or break features as happened here. |
|
I can add some docs + tests in this PR if preferred, but very likely to need some help from @staticfloat (or could do that in a seperate PR which I guess would be faster to get this PR merged?) PS. @KristofferC can we backport this if it's not too late? |
|
Yes, it seems to be a standard bugfix. |
KristofferC
added
backport 1.6
|
Yep, this is definitely a regression; we absolutely want to support dicts. Roger, adding docs and tests in a separate PR would be great, please ping me when you do so and I'll provide guidance/feedback. |
KristofferC
pushed a commit
that referenced
this pull request
Jun 26, 2021
(cherry picked from commit 7553ca1)
51 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jun 29, 2021
(cherry picked from commit 7553ca1)
45 tasks
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
KristofferC
removed
backport 1.7
backport 1.6
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
(cherry picked from commit 7553ca1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix JuliaPackaging/Preferences.jl#16 kinda revert the type annotation added in #38285 since we don't know the type of a value IIUC unless we want to restrict the preference value to be
Stringonly.I'm not sure where to add a test for this, or
get_preferences_hashwasn't tested at all?guess cc: @staticfloat