Drop parens from JULIA_DEFINE_FAST_TLS in embedding.{c,md} to match recent redefinition. #41309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecent redefinition.
|
Requesting review from Takafumi and Jameson as IIRC the authors of the (awesome) recent relevant work. Please feel welcome to reassign review if someone else would be more appropriate :). |
vtjnash
approved these changes
Jun 22, 2021
There was a problem hiding this comment.
I thought we used to run the embedding tests on CI. @staticfloat do you know what happened to them?
|
Thanks for reviewing Jameson! :) |
|
Looks like they were a casualty of #37976 We should move them to buildkite. I'll open an issue. |
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trailing parens were recently dropped from JULIA_DEFINE_FAST_TLS, but it looks like two instances in embedding.{c,md} might've been missed. Best! :)