Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #41346, update Random docs for Xoshiro256++ #41353

Merged
merged 1 commit into from
Jun 29, 2021
Merged

fix #41346, update Random docs for Xoshiro256++ #41353

merged 1 commit into from
Jun 29, 2021

Conversation

JeffBezanson
Copy link
Member

fix #41346

@JeffBezanson JeffBezanson added docs This change adds or pertains to documentation backport 1.7 labels Jun 24, 2021
Sacha0
Sacha0 approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Seelengrab
Copy link
Contributor

Seelengrab commented Jun 25, 2021 •
edited
Loading

Yes, looks good! Now just the docstrings are missing, they prevalently mention MersenneTwister (and some things that no longer exist (I think) like GLOBAL_RNG) as well. Can be a different PR though, but shouldn't be missed for 1.7, imo.

@KristofferC KristofferC mentioned this pull request Jun 26, 2021
Merged
51 tasks
@JeffBezanson
Copy link
Member Author

Ok, thanks --- I found an instance of MersenneTwister in the manual. GLOBAL_RNG still exists. I see other cases where MersenneTwister is used as an example, but those still work so I'm not sure they need to change.

@JeffBezanson JeffBezanson merged commit 7c566b1 into master Jun 29, 2021
@JeffBezanson JeffBezanson deleted the jb/randomdocs branch June 29, 2021 22:37
KristofferC pushed a commit that referenced this pull request Jun 30, 2021
@JeffBezanson @KristofferC
fix #41346, update Random docs for Xoshiro256++ (#41353)
921b3a3 
(cherry picked from commit 7c566b1)
@rfourquet rfourquet added the randomness Random number generation and the Random stdlib label Jul 1, 2021
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@JeffBezanson @johanmon
fix JuliaLang#41346, update Random docs for Xoshiro256++ (JuliaLang#4…
ba1ab35 
…1353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation randomness Random number generation and the Random stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Random doc still talks about MersenneTwister instead of xoroshiro
5 participants
@JeffBezanson @Seelengrab @Sacha0 @KristofferC @rfourquet