Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add more Debian packages to the llvm-passes rootfs image #41544

Merged
merged 2 commits into from
Jul 11, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jul 11, 2021

  • We need bash for the test suite.
  • We need less for the doctests.
  • Also, sort the entries of packages in alphabetical order to make it easier to find specific entries in the list.

Also, sort the entries of `packages` in alphabetical order.
@DilumAluthge DilumAluthge added the ci Continuous integration label Jul 11, 2021
@DilumAluthge DilumAluthge requested a review from staticfloat July 11, 2021 05:11
@DilumAluthge DilumAluthge requested a review from a team as a code owner July 11, 2021 05:11
@DilumAluthge DilumAluthge removed the request for review from a team July 11, 2021 05:11
@DilumAluthge DilumAluthge changed the title CI: Add less to the llvm-passes rootfs image CI: Add less and bash to the llvm-passes rootfs image Jul 11, 2021
@DilumAluthge DilumAluthge changed the title CI: Add less and bash to the llvm-passes rootfs image CI: Add more Debian packages to the llvm-passes rootfs image Jul 11, 2021
@DilumAluthge
Copy link
Member Author

DilumAluthge commented Jul 11, 2021

After this PR is merged, how do I generate the new rootfs image and upload it to https://github.com/JuliaCI/rootfs-images?

E.g. do I just need to run julia llvm-passes.jl on a Debian machine, and it will do the upload and everything?

@DilumAluthge DilumAluthge merged commit 516af1b into master Jul 11, 2021
@DilumAluthge DilumAluthge deleted the dpa/buildkite_less branch July 11, 2021 21:01
@DilumAluthge
Copy link
Member Author

For posterity, here's a setup that worked for me:

On your local machine, run these commands:

$ git clone git@github.com:JuliaLang/julia.git
$ docker run --privileged --rm -it -v $(pwd):/root/workspace julia:buster /bin/bash

Now, inside the Docker container, run these commands:

# cd
# apt-get update && apt-get -y install debootstrap sudo
# cd /root/workspace/julia/.buildkite/rootfs_images/
# rm -rf ~/.julia
# julia -e 'using Pkg; Pkg.add(["Scratch", "ghr_jll"]); Pkg.update()'
# julia -e 'using Pkg; Pkg.precompile()'
# export GITHUB_TOKEN="my-github-token-goes-here"
# julia llvm-passes.jl

@staticfloat
Copy link
Member

Why do we need gfortran for LLVM passes?

@DilumAluthge
Copy link
Member Author

Good question. It was already in the list previously, so I didn't remove it.

@staticfloat
Copy link
Member

Oh, right, of course, we build Julia here. I had this confused with analyzegc.

@DilumAluthge
Copy link
Member Author

Should I keep overwriting the v1 tag, or should I make new tags v1.1, v1.2, etc?

@staticfloat
Copy link
Member

We should not overwrite anything used by older CI runs, if we can help it.

@KristofferC KristofferC added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Jul 13, 2021
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
* Add `less` to the `llvm-passes` rootfs image

Also, sort the entries of `packages` in alphabetical order.

* Update llvm-passes.jl

(cherry picked from commit 516af1b)
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
* Add `less` to the `llvm-passes` rootfs image

Also, sort the entries of `packages` in alphabetical order.

* Update llvm-passes.jl

(cherry picked from commit 516af1b)
@KristofferC KristofferC mentioned this pull request Jul 19, 2021
75 tasks
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
* Add `less` to the `llvm-passes` rootfs image

Also, sort the entries of `packages` in alphabetical order.

* Update llvm-passes.jl

(cherry picked from commit 516af1b)
KristofferC pushed a commit that referenced this pull request Aug 31, 2021
* Add `less` to the `llvm-passes` rootfs image

Also, sort the entries of `packages` in alphabetical order.

* Update llvm-passes.jl

(cherry picked from commit 516af1b)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Sep 7, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
* Add `less` to the `llvm-passes` rootfs image

Also, sort the entries of `packages` in alphabetical order.

* Update llvm-passes.jl

(cherry picked from commit 516af1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants