Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default "auto" as option to --check-bounds #41551

Merged

Conversation

IanButterworth
Copy link
Member

It seems to be unusual that neither of the --check-bounds={yes|no} options are the default state, so this adds "auto" to make it --check-bounds={yes|no|auto}

It would make overruling this arg back to default state possible, for instance in JuliaLang/Pkg.jl#2668 (although that can be fixed in other ways)

@IanButterworth
Copy link
Member Author

Who's a good reviewer for this? @vtjnash perhaps?

@DilumAluthge DilumAluthge requested a review from vtjnash July 12, 2021 19:25
@IanButterworth IanButterworth added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Jul 12, 2021
@JeffBezanson
Copy link
Member

Looks fine to me, but this is not the kind of thing we would usually backport.

@IanButterworth
Copy link
Member Author

My rationale for backporting to 1.6 was that this would be helpful for julia-actions/julia-runtest#46
If it's not backported to the LTS, the user would have to guard in CI to not send --check-bounds=auto to the LTS, assuming they test on LTS and latest.
And thus couldn't run CI tests with the julia default bounds checking.

I thought the default not being available as an option was more of a bug than a missing feature? That's probably a thin argument though

@JeffBezanson
Copy link
Member

Yeah, it's a borderline case, and indeed difficult to see this causing any problem. I guess it might be ok to backport, but I would probably not add it to the HISTORY file.

@IanButterworth
Copy link
Member Author

Ok. I'll watch out for when it gets backported. I couldn't see a label for "requires manual backport". Perhaps that would help

@IanButterworth IanButterworth merged commit 7d0f769 into JuliaLang:master Jul 13, 2021
@IanButterworth IanButterworth deleted the ib/checkbounds_auto_opt branch July 13, 2021 12:54
@KristofferC KristofferC mentioned this pull request Jul 19, 2021
75 tasks
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
* add default "auto" as option to --check-bounds

* add to NEWS

(cherry picked from commit 7d0f769)
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
* add default "auto" as option to --check-bounds

* add to NEWS

(cherry picked from commit 7d0f769)
KristofferC pushed a commit that referenced this pull request Jul 20, 2021
* add default "auto" as option to --check-bounds

* add to NEWS

(cherry picked from commit 7d0f769)
KristofferC pushed a commit that referenced this pull request Jul 20, 2021
* add default "auto" as option to --check-bounds

* add to NEWS

(cherry picked from commit 7d0f769)
KristofferC pushed a commit that referenced this pull request Aug 31, 2021
* add default "auto" as option to --check-bounds

* add to NEWS

(cherry picked from commit 7d0f769)
KristofferC pushed a commit that referenced this pull request Sep 3, 2021
* add default "auto" as option to --check-bounds

* add to NEWS

(cherry picked from commit 7d0f769)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Sep 7, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
* add default "auto" as option to --check-bounds

* add to NEWS

(cherry picked from commit 7d0f769)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants