-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add default "auto" as option to --check-bounds #41551
add default "auto" as option to --check-bounds #41551
Conversation
Who's a good reviewer for this? @vtjnash perhaps? |
Looks fine to me, but this is not the kind of thing we would usually backport. |
My rationale for backporting to 1.6 was that this would be helpful for julia-actions/julia-runtest#46 I thought the default not being available as an option was more of a bug than a missing feature? That's probably a thin argument though |
Yeah, it's a borderline case, and indeed difficult to see this causing any problem. I guess it might be ok to backport, but I would probably not add it to the HISTORY file. |
Ok. I'll watch out for when it gets backported. I couldn't see a label for "requires manual backport". Perhaps that would help |
* add default "auto" as option to --check-bounds * add to NEWS (cherry picked from commit 7d0f769)
* add default "auto" as option to --check-bounds * add to NEWS (cherry picked from commit 7d0f769)
* add default "auto" as option to --check-bounds * add to NEWS (cherry picked from commit 7d0f769)
* add default "auto" as option to --check-bounds * add to NEWS (cherry picked from commit 7d0f769)
* add default "auto" as option to --check-bounds * add to NEWS (cherry picked from commit 7d0f769)
* add default "auto" as option to --check-bounds * add to NEWS (cherry picked from commit 7d0f769)
* add default "auto" as option to --check-bounds * add to NEWS (cherry picked from commit 7d0f769)
It seems to be unusual that neither of the
--check-bounds={yes|no}
options are the default state, so this adds "auto" to make it--check-bounds={yes|no|auto}
It would make overruling this arg back to default state possible, for instance in JuliaLang/Pkg.jl#2668 (although that can be fixed in other ways)