Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get-task-allow entitlement #41559

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Fix get-task-allow entitlement #41559

merged 1 commit into from
Jul 12, 2021

Conversation

staticfloat
Copy link
Sponsor Member

We had apparently misspelled this entitlement, not allowing lldb to attach to official macOS builds.

@staticfloat
Fix get-task-allow entitlement
b554e06 
We had apparently misspelled this entitlement, not allowing `lldb` to attach to official macOS builds.
@staticfloat staticfloat added system:mac Affects only macOS backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Jul 12, 2021
@staticfloat
Copy link
Sponsor Member Author

Thanks for the heads-up @notinaboat!

@staticfloat staticfloat mentioned this pull request Jul 12, 2021
Merged
Sacha0
Sacha0 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficially LGTM :)

@staticfloat staticfloat merged commit ad6740b into master Jul 12, 2021
@staticfloat staticfloat deleted the sf/get-task-allow branch July 12, 2021 23:17
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
@staticfloat @KristofferC
Fix get-task-allow entitlement (#41559)
38bff97 
We had apparently misspelled this entitlement, not allowing `lldb` to attach to official macOS builds.

(cherry picked from commit ad6740b)
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
@staticfloat @KristofferC
Fix get-task-allow entitlement (#41559)
62a3b89 
We had apparently misspelled this entitlement, not allowing `lldb` to attach to official macOS builds.

(cherry picked from commit ad6740b)
@KristofferC KristofferC mentioned this pull request Jul 19, 2021
Merged
75 tasks
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
@staticfloat @KristofferC
Fix get-task-allow entitlement (#41559)
9ae40be 
We had apparently misspelled this entitlement, not allowing `lldb` to attach to official macOS builds.

(cherry picked from commit ad6740b)
@KristofferC KristofferC mentioned this pull request Jul 19, 2021
Merged
82 tasks
@KristofferC KristofferC mentioned this pull request Aug 25, 2021
Merged
63 tasks
@ihnorton
Copy link
Member

For anyone else who might hit this in 1.6.2, work-around is:

  1. create self-signing cert: this plus this comment
  2. dump the entitlements: codesign -d --entitlements :/tmp/ent.xml /opt/Julia-1.6.app/Contents/Resources/julia/bin/julia (note the : before path to strip the binary blob prefix, or else it won't be readable by codesign after editing)
  3. edit /tmp/ent.xml as in this diff
  4. re-sign using your self-signing cert from (1): codesign -d --entitlements /tmp/ent.xml -f -s "gdb_cert2" /opt/Julia-1.6.app/Contents/Resources/julia/bin/julia

KristofferC pushed a commit that referenced this pull request Aug 31, 2021
@staticfloat @KristofferC
Fix get-task-allow entitlement (#41559)
667c883 
We had apparently misspelled this entitlement, not allowing `lldb` to attach to official macOS builds.

(cherry picked from commit ad6740b)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Sep 7, 2021
staticfloat added a commit that referenced this pull request Dec 23, 2022
@staticfloat
Fix get-task-allow entitlement (#41559)
55564c8 
We had apparently misspelled this entitlement, not allowing `lldb` to attach to official macOS builds.

(cherry picked from commit ad6740b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
system:mac Affects only macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@staticfloat @ihnorton @Sacha0 @KristofferC