Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

while loop -> for loop in _simplify_include_frames (fixes #41566) #41622

Merged
merged 2 commits into from
Jul 20, 2021
Merged

while loop -> for loop in _simplify_include_frames (fixes #41566) #41622

merged 2 commits into from
Jul 20, 2021

Conversation

fredcallaway
Copy link
Contributor

prevents the possibility of a bounds error when i = 0

@fredcallaway
while loop -> for loop in _simplify_include_frames (fixes #41566)
f1e33bd 
prevents the possibility of a bounds error when i = 0
thchr
thchr reviewed Jul 17, 2021
View reviewed changes
base/errorshow.jl Outdated Show resolved Hide resolved
@fredcallaway @thchr
Remove spurious i -= 1
85ba3c2 
Co-authored-by: Thomas Christensen <tchr@mit.edu>
@KristofferC KristofferC added backport 1.6 Change should be backported to release-1.6 backport 1.7 bugfix This change fixes an existing bug labels Jul 17, 2021
This was referenced Jul 19, 2021
Merged
Merged
@KristofferC KristofferC merged commit ed4f316 into JuliaLang:master Jul 20, 2021
KristofferC pushed a commit that referenced this pull request Jul 26, 2021
@fredcallaway @KristofferC
while loop -> for loop in _simplify_include_frames (fixes #41566) (#4…
77a5810 
…1622)

* while loop -> for loop in _simplify_include_frames (fixes #41566)

prevents the possibility of a bounds error when i = 0

(cherry picked from commit ed4f316)
KristofferC pushed a commit that referenced this pull request Jul 26, 2021
@fredcallaway @KristofferC
while loop -> for loop in _simplify_include_frames (fixes #41566) (#4…
aa9827f 
…1622)

* while loop -> for loop in _simplify_include_frames (fixes #41566)

prevents the possibility of a bounds error when i = 0

(cherry picked from commit ed4f316)
@KristofferC KristofferC mentioned this pull request Aug 25, 2021
Merged
63 tasks
KristofferC pushed a commit that referenced this pull request Aug 31, 2021
@fredcallaway @KristofferC
while loop -> for loop in _simplify_include_frames (fixes #41566) (#4…
22e7e24 
…1622)

* while loop -> for loop in _simplify_include_frames (fixes #41566)

prevents the possibility of a bounds error when i = 0

(cherry picked from commit ed4f316)
KristofferC pushed a commit that referenced this pull request Sep 3, 2021
@fredcallaway @KristofferC
while loop -> for loop in _simplify_include_frames (fixes #41566) (#4…
0aa1835 
…1622)

* while loop -> for loop in _simplify_include_frames (fixes #41566)

prevents the possibility of a bounds error when i = 0

(cherry picked from commit ed4f316)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Sep 7, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@fredcallaway @staticfloat
while loop -> for loop in _simplify_include_frames (fixes #41566) (#4…
15e37d5 
…1622)

* while loop -> for loop in _simplify_include_frames (fixes #41566)

prevents the possibility of a bounds error when i = 0

(cherry picked from commit ed4f316)
@LilithHafner LilithHafner mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thchr thchr thchr left review comments

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredcallaway @thchr @KristofferC