Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: delete the .buildkite/rootfs_images directory #41648

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jul 20, 2021

This PR deletes the .buildkite/rootfs_images directory from the JuliaLang/julia repository.

I have already copied the contents of the .buildkite/rootfs_images directory to the JuliaCI/rootfs-images repository.

Here is my reasoning for this change:

  1. The release assets are already hosted in the JuliaCI/rootfs-images repository, so I think it makes sense for the code to live there.
  2. Having the code live in the JuliaCI/rootfs-images repository makes it easier to go from release asset to the code that was used to generate that release asset, and vice versa.
  3. The GitHub Actions CI in the JuliaCI/rootfs-images repository allows us to automate the build process of the rootfs images, instead of needing to do it manually.
  4. The GitHub Actions CI in the JuliaCI/rootfs-images repository generates valid rootfs images, in contrast to other setups (like the Docker setup I tried out with v1.1). For example, it fixed the issue I was having in #41606).

Note that even though we are moving the code for generating rootfs images to an external repository, this doesn't change the fact that in the JuliaLang/julia repository, we will still pin each pipeline to a specific version of a rootfs images by specifying both the rootfs_url and rootfs_treehash in a file that is checked into source control in the JuliaLang/julia repository.

Therefore:

  1. Our Buildkite builds will still be reproducible, because we specify the rootfs_treehash.
  2. Different permanent branches of Julia (master and release-*) can still use different versions of the rootfs images.

@DilumAluthge DilumAluthge added the ci Continuous integration label Jul 20, 2021
@DilumAluthge DilumAluthge requested a review from staticfloat July 20, 2021 06:56
@DilumAluthge DilumAluthge requested a review from a team as a code owner July 20, 2021 06:56
@DilumAluthge DilumAluthge removed the request for review from a team July 20, 2021 06:56
@DilumAluthge DilumAluthge added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Jul 20, 2021
@DilumAluthge DilumAluthge force-pushed the dpa/delete_rootfs_images_directory branch from d893ef9 to eb7bf14 Compare July 21, 2021 04:21
@staticfloat staticfloat merged commit 61b6994 into master Jul 21, 2021
@staticfloat staticfloat deleted the dpa/delete_rootfs_images_directory branch July 21, 2021 17:10
KristofferC pushed a commit that referenced this pull request Jul 26, 2021
KristofferC pushed a commit that referenced this pull request Jul 26, 2021
@KristofferC KristofferC mentioned this pull request Jul 26, 2021
75 tasks
KristofferC pushed a commit that referenced this pull request Aug 31, 2021
KristofferC pushed a commit that referenced this pull request Sep 3, 2021
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Sep 7, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants