ml-matches: fix performance trap #41925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While normally we try to only call `jl_type_morespecific` on types with a non-empty intersection (to be more precise about ambiguity reporting), the only work we would do here (if the intersect is empty) would also be to call continue. Fixes #41518
JeffBezanson
approved these changes
Aug 24, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
While normally we try to only call `jl_type_morespecific` on types with a non-empty intersection (to be more precise about ambiguity reporting), the only work we would do here (if the intersect is empty) would also be to call continue. Fixes JuliaLang#41518
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
While normally we try to only call `jl_type_morespecific` on types with a non-empty intersection (to be more precise about ambiguity reporting), the only work we would do here (if the intersect is empty) would also be to call continue. Fixes JuliaLang#41518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While normally we try to only call
jl_type_morespecificon types witha non-empty intersection (to be more precise about ambiguity reporting),
the only work we would do here (if the intersect is empty) would also be
to call continue.
Fixes #41518