Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inference: bail from const-prop if const-prop fails #42112

Merged
merged 1 commit into from
Sep 8, 2021
Merged

inference: bail from const-prop if const-prop fails #42112

merged 1 commit into from
Sep 8, 2021

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Sep 3, 2021

Otherwise we can can end up in an infinite cycle of attempting
const-prop, and that failing. Also handle Varargs in method-lookup
matching, which was the cause for which we could not compute the
const-prop signature.

Fixes #42097

@vtjnash vtjnash added bugfix This change fixes an existing bug compiler:inference Type inference backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Sep 3, 2021
@vtjnash vtjnash requested a review from aviatesk September 3, 2021 18:21
aviatesk
aviatesk approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid.

@aviatesk aviatesk added merge me PR is reviewed. Merge when all tests are passing and removed merge me PR is reviewed. Merge when all tests are passing labels Sep 4, 2021
@aviatesk
Copy link
Member

aviatesk commented Sep 4, 2021

Oh, still needs rebase to take in the changes of #42082 : frame = InferenceState(inf_result, #=cache=#:local, interp)

@KristofferC KristofferC mentioned this pull request Sep 7, 2021
Merged
95 tasks
@vtjnash @aviatesk
inference: bail from const-prop if const-prop fails
d51b1d1 
Otherwise we can can end up in an infinite cycle of attempting
const-prop, and that failing. Also handle Varargs in method-lookup
matching, which was the cause for which we could not compute the
const-prop signature.

Fixes #42097
@aviatesk aviatesk added the merge me PR is reviewed. Merge when all tests are passing label Sep 8, 2021
@aviatesk aviatesk merged commit 3a4198e into master Sep 8, 2021
@aviatesk aviatesk deleted the jn/42097 branch September 8, 2021 06:32
KristofferC pushed a commit that referenced this pull request Sep 8, 2021
@vtjnash @KristofferC
inference: bail from const-prop if const-prop fails (#42112)
886b922 
Otherwise we can end up in an infinite cycle of attempting
const-prop, and that failing. Also handle `Varargs` in method-lookup
matching, which was the cause for which we could not compute the
const-prop signature.

Fixes #42097

(cherry picked from commit 3a4198e)
KristofferC pushed a commit that referenced this pull request Sep 8, 2021
@vtjnash @KristofferC
inference: bail from const-prop if const-prop fails (#42112)
c2c5a83 
Otherwise we can end up in an infinite cycle of attempting
const-prop, and that failing. Also handle `Varargs` in method-lookup
matching, which was the cause for which we could not compute the
const-prop signature.

Fixes #42097

(cherry picked from commit 3a4198e)
@KristofferC KristofferC mentioned this pull request Sep 8, 2021
Merged
63 tasks
aviatesk pushed a commit that referenced this pull request Sep 9, 2021
@vtjnash @aviatesk
inference: bail from const-prop if const-prop fails (#42112)
93f40a0 
Otherwise we can end up in an infinite cycle of attempting
const-prop, and that failing. Also handle `Varargs` in method-lookup
matching, which was the cause for which we could not compute the
const-prop signature.

Fixes #42097

cherry-picked from 3a4198e
@aviatesk aviatesk mentioned this pull request Sep 9, 2021
Merged
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Sep 9, 2021
@KristofferC KristofferC mentioned this pull request Nov 8, 2021
Merged
66 tasks
@KristofferC KristofferC mentioned this pull request Nov 19, 2021
Merged
29 tasks
@KristofferC KristofferC mentioned this pull request Jan 10, 2022
Merged
50 tasks
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@vtjnash @LilithHafner
inference: bail from const-prop if const-prop fails (JuliaLang#42112)
a86a98b 
Otherwise we can end up in an infinite cycle of attempting
const-prop, and that failing. Also handle `Varargs` in method-lookup
matching, which was the cause for which we could not compute the
const-prop signature.

Fixes JuliaLang#42097
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@vtjnash @LilithHafner
inference: bail from const-prop if const-prop fails (JuliaLang#42112)
32fe9dd 
Otherwise we can end up in an infinite cycle of attempting
const-prop, and that failing. Also handle `Varargs` in method-lookup
matching, which was the cause for which we could not compute the
const-prop signature.

Fixes JuliaLang#42097
@KristofferC
Copy link
Member

Needs a manual backport against backports-release-1.6.

@KristofferC KristofferC mentioned this pull request May 16, 2022
Merged
45 tasks
@KristofferC KristofferC mentioned this pull request Jul 20, 2022
Closed
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviatesk aviatesk aviatesk approved these changes

Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6 bugfix This change fixes an existing bug compiler:inference Type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.7-beta4: Internal error: encountered unexpected error in runtime
4 participants
@vtjnash @aviatesk @KristofferC @DilumAluthge