Allow modules to optionally import nothing at all - final bits #42154
Conversation
NEWS.md
Outdated
| * `(; a, b) = x` can now be used to destructure properties `a` and `b` of `x`. This syntax is equivalent to `a = getproperty(x, :a)` | ||
| and similarly for `b`. ([#39285]) |
There was a problem hiding this comment.
This was in my old branch, but not in master, but I think it should still be in the master branch, perhaps it was removed accidentally?
There was a problem hiding this comment.
The feature is added for v1.7, and this is a release note for v1.8.
There was a problem hiding this comment.
Oh, so it is. Well, perhaps I should merge this with a different branch or against a different tag or something?
Maybe 7ca1a90 ? (one commit before Kristoffer Carlsson updated VERSION)?
There was a problem hiding this comment.
Please rebase on master. We first merge things against master and later one backport if needed.
|
This should be in 1.7 but master has moved on. Very sorry for the inconvenience. Let me know if you'd like me to rebase these changes onto e.g. 7ca1a90 (one commit before Kristoffer Carlsson updated VERSION) or if you'd like me to present a smaller changeset (e.g. only fixing src/module.c so that empty modules don't contain a reference to themselves). |
| @@ -428,7 +428,8 @@ eval(Core, :(InterConditional(slot::Int, @nospecialize(vtype), @nospecialize(els | |||
| eval(Core, :(MethodMatch(@nospecialize(spec_types), sparams::SimpleVector, method::Method, fully_covers::Bool) = | |||
| $(Expr(:new, :MethodMatch, :spec_types, :sparams, :method, :fully_covers)))) | |||
|
|
|||
| Module(name::Symbol=:anonymous, std_imports::Bool=true, using_core::Bool=true) = ccall(:jl_f_new_module, Ref{Module}, (Any, Bool, Bool), name, std_imports, using_core) | |||
There was a problem hiding this comment.
This is breaking, since it removes the 3-argument version. We should still allow it.
There was a problem hiding this comment.
Cool. Would you prefer that I leave the Julia interface unchanged and just fix src/module.c so that empty modules don't include their own name?
Is it okay if I rename the argument using_core to default_names?
There was a problem hiding this comment.
Oh sorry, I didn't realize this hadn't been released yet, so it's not actually breaking. The current version of the PR is fine with me though.
cmcaine
force-pushed
the
barer-baremodule2
branch
from
3832094 to
dff88cf
Compare
|
Rebased into two commits on master. I've left the Julia interface unchanged from #40110 because it doesn't seem worth it to change it. |
Exclude modules own name from empty modules
…Lang#42154) Exclude modules own name from empty modules
…Lang#42154) Exclude modules own name from empty modules
I never got around to addressing Jeff's suggestion that empty modules should not contain a reference to themselves.
This PR (which I wrote in March but didn't push for some reason D:) addresses that and also tweaks the interface and the docs slightly.