Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #42411, restore export of jl_options #42416

Merged
merged 2 commits into from
Sep 30, 2021
Merged

fix #42411, restore export of jl_options #42416

merged 2 commits into from
Sep 30, 2021

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added embedding Embedding Julia using the C API backport 1.7 labels Sep 28, 2021
vtjnash
vtjnash reviewed Sep 28, 2021
View reviewed changes
cli/loader_lib.c Outdated Show resolved Hide resolved
@KristofferC KristofferC mentioned this pull request Sep 29, 2021
Merged
84 tasks
@JeffBezanson @vtjnash
Update cli/loader_lib.c
713579c 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Sep 30, 2021
@JeffBezanson JeffBezanson merged commit c5cb029 into master Sep 30, 2021
@JeffBezanson JeffBezanson deleted the jb/jloptions branch September 30, 2021 20:12
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 2, 2021
KristofferC pushed a commit that referenced this pull request Oct 5, 2021
@JeffBezanson @KristofferC
fix #42411, restore export of jl_options (#42416)
d42ae5a 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
(cherry picked from commit c5cb029)
@mkitti mkitti mentioned this pull request Oct 23, 2021
Closed
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@JeffBezanson @vtjnash @LilithHafner
fix JuliaLang#42411, restore export of jl_options (JuliaLang#42416)
b201459 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@JeffBezanson @vtjnash @LilithHafner
fix JuliaLang#42411, restore export of jl_options (JuliaLang#42416)
02e1392 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@musm
Copy link
Contributor

musm commented Mar 30, 2022

This is missing a backport for 1.6. It should've made into the 1.6.x release, but was missed.

@musm
Copy link
Contributor

musm commented Mar 30, 2022

We just noticed this as we were trying to call this option without success on 1.6, but it works on 1.7 and 1.5.
I've added the appropriate backport label. @KristofferC this is my first time with adding the label, so please let me know if I need to do anything else.

@musm musm added the backport 1.6 Change should be backported to release-1.6 label Mar 30, 2022
@JeffBezanson JeffBezanson mentioned this pull request May 12, 2022
Closed
@Taaitaaiger Taaitaaiger mentioned this pull request May 13, 2022
Merged
@KristofferC KristofferC mentioned this pull request May 16, 2022
Merged
45 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 23, 2022
@KristofferC
Copy link
Member

Backported in #45308.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
embedding Embedding Julia using the C API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeffBezanson @musm @KristofferC @vtjnash @DilumAluthge