Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
setcpuaffinity(cmd, cpus)
for setting CPU affinity of subprocesses #42469Add
setcpuaffinity(cmd, cpus)
for setting CPU affinity of subprocesses #42469Changes from 7 commits
d501456
2a72e24
17eadca
9af2985
a59228e
d65cacd
ba5559f
4d37558
7edc261
038c116
7739a25
994e081
20618b9
fa1b115
e446956
b9feb8d
304330e
a83b105
1beffff
21ff94d
123a072
70138f4
24763b0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic required to go from the first command to understand the point of the second feels a bit large here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good point. I added a bit more explanations in the latest commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm against dispatching on
Bool
element type to change the meaning (in general). It will change the behavior betweencpus = Bool[true]
andcpus = Integer[true]
(orAny[true]
). I prefer to add a distinct function likesetcpuaffinitymask
or maybe aMask
type for supporting this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find where
show(::IO, ::Cmd)
was tested. It looks like the original commit dee7f6c didn't add the test forshow
withsetenv
. So, I just threw this in for completeness.