-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed test suite: add an additional use of the poll_while
function
#42758
Conversation
I'm not sure if this change actually makes any sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's from multi-threaded tests, I don't think this is unexpected? I think it'd be better to move tester_linux64_mt
(or only Distributed's tests) to experimental or skip this test when nthreads()> 1
.
I think moving multithreaded tests for Distributed to experimental would be better than skipping it since we can do some post-hoc analysis on how much flaky it has been.
Hmmm. I definitely don't want to mark the entire I guess we could make a separate job that specifically runs the |
Hmmm. This doesn't fix the case where someone runs the tests locally with e.g. If this test is known/expected to sometimes fail when Julia was started with multiple threads, I think I would prefer to go with your suggestion of skipping those specific tests if |
Actually, we can do both. We can skip it by default, but have a Buildkite job that doesn't skip it. |
Follow-up to #42499
This pull request is intended to fix the following test failure, which I am seeing very rarely in the
tester_linux64_mt
Buildkite job:Full log: https://buildkite.com/julialang/julia-master/builds/5028#dfdf3a45-5510-402b-99d4-9daa860f0f09