Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fix mapreduce_first docstring error #42832

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

st--
Copy link
Contributor

@st-- st-- commented Oct 28, 2021

The docstring of Base.mapreduce_first referred reduce_first(op, f, x), but reduce_first is a 2-argument function, and it should refer to mapreduce_first instead.

base/reduce.jl Outdated Show resolved Hide resolved
@st--
Copy link
Contributor Author

st-- commented Nov 15, 2022

This doc fix is still relevant.

@st-- st-- changed the title Fix mapreduce_first docstring error Doc: Fix mapreduce_first docstring error Nov 15, 2022
@dkarrasch dkarrasch added the docs This change adds or pertains to documentation label Nov 15, 2022
Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkarrasch dkarrasch added the merge me PR is reviewed. Merge when all tests are passing label Nov 15, 2022
The docstring of Base.mapreduce_first referred `reduce_first(op, f, x)`, but `reduce_first` is a 2-argument function, and it should refer to `mapreduce_first(f, op, x)` instead.
@giordano giordano merged commit 7262534 into JuliaLang:master Nov 22, 2022
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants