-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially revert #42919 #42969
Merged
Merged
Partially revert #42919 #42969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to RPATH setting for macOS seems to have improved the situation for users on Monterey, but the other changes in #42919 that affect other platforms seem to have caused regressions on musl Linux (#42940) and FreeBSD (#42944). The easiest thing to do here is to keep the changes from #42919 as they apply to macOS but revert the others.
ararslan
added
building
Build system, or building Julia or its dependencies
bugfix
This change fixes an existing bug
labels
Nov 6, 2021
staticfloat
requested changes
Nov 6, 2021
If you look at the logs, in its current state (86c2d80) this PR fixes both musl64 and freebsd64. |
In its current state (023d4ca) this PR fixes both musl64 and freebsd64. |
Just a note in case anyone is wondering whether this will impact the fixes for macOS Monterey: The full conditional is Lines 1189 to 1205 in 023d4ca
Lines 1200 to 1205 in 023d4ca
|
staticfloat
approved these changes
Nov 6, 2021
KristofferC
pushed a commit
that referenced
this pull request
Nov 7, 2021
* Partially revert #42919 The change to RPATH setting for macOS seems to have improved the situation for users on Monterey, but the other changes in #42919 that affect other platforms seem to have caused regressions on musl Linux (#42940) and FreeBSD (#42944). The easiest thing to do here is to keep the changes from #42919 as they apply to macOS but revert the others. * Un-revert the `RPATH_LIB` definition (cherry picked from commit 653cad3)
66 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
* Partially revert JuliaLang#42919 The change to RPATH setting for macOS seems to have improved the situation for users on Monterey, but the other changes in JuliaLang#42919 that affect other platforms seem to have caused regressions on musl Linux (JuliaLang#42940) and FreeBSD (JuliaLang#42944). The easiest thing to do here is to keep the changes from JuliaLang#42919 as they apply to macOS but revert the others. * Un-revert the `RPATH_LIB` definition
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
* Partially revert JuliaLang#42919 The change to RPATH setting for macOS seems to have improved the situation for users on Monterey, but the other changes in JuliaLang#42919 that affect other platforms seem to have caused regressions on musl Linux (JuliaLang#42940) and FreeBSD (JuliaLang#42944). The easiest thing to do here is to keep the changes from JuliaLang#42919 as they apply to macOS but revert the others. * Un-revert the `RPATH_LIB` definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to RPATH setting for macOS seems to have improved the situation for users on Monterey, but the other changes in #42919 that affect other platforms seem to have caused regressions on musl Linux (#42940) and FreeBSD (#42944). The easiest thing to do here is to keep the changes from #42919 as they apply to macOS but revert the others.
Fixes #42940
Fixes #42944