Avoid -Wunused-function
on macOS for some Float16
intrinsics
#43174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're defining
half_to_float
andfloat_to_half
unconditionally but only ever calling them on non-Mac platforms, so Clang produces unused function warnings during the build on macOS. To fix this, we can just move the platform check to encompass the definitions in addition to the uses.These functions were added in #37510. Do let me know if having these outside of the platform check was intentional and/or would have adverse downstream effects. If not, this should be safe (but far from critical) to backport to 1.6 and 1.7.