Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify norm computations. #43190

Merged
merged 6 commits into from
Nov 29, 2021
Merged

simplify norm computations. #43190

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6187bf6
simplify norm computations.
oscardssmith Nov 22, 2021
c56c0ca
fix
oscardssmith Nov 22, 2021
032e132
fix2
oscardssmith Nov 22, 2021
022538f
fix norm of array of array
oscardssmith Nov 22, 2021
e7ced9b
make sure `norm` always returns a float.
oscardssmith Nov 23, 2021
fe79216
help type stability.
oscardssmith Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 3 additions & 37 deletions stdlib/LinearAlgebra/src/generic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,45 +449,11 @@ diag(A::AbstractVector) = throw(ArgumentError("use diagm instead of diag to cons
# Dot products and norms

# special cases of norm; note that they don't need to handle isempty(x)
function generic_normMinusInf(x)
(v, s) = iterate(x)::Tuple
minabs = norm(v)
while true
y = iterate(x, s)
y === nothing && break
(v, s) = y
vnorm = norm(v)
minabs = ifelse(isnan(minabs) | (minabs < vnorm), minabs, vnorm)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note, this line can now be removed due to #12563 which makes #12564 redundant.

end
return float(minabs)
end
generic_normMinusInf(x) = float(mapreduce(norm, min, x))

function generic_normInf(x)
(v, s) = iterate(x)::Tuple
maxabs = norm(v)
while true
y = iterate(x, s)
y === nothing && break
(v, s) = y
vnorm = norm(v)
maxabs = ifelse(isnan(maxabs) | (maxabs > vnorm), maxabs, vnorm)
end
return float(maxabs)
end
generic_normInf(x) = float(mapreduce(norm, max, x))

function generic_norm1(x)
(v, s) = iterate(x)::Tuple
av = float(norm(v))
T = typeof(av)
sum::promote_type(Float64, T) = av
while true
y = iterate(x, s)
y === nothing && break
(v, s) = y
sum += norm(v)
end
return convert(T, sum)
end
generic_norm1(x) = mapreduce(float ∘ norm, +, x)

# faster computation of norm(x)^2, avoiding overflow for integers
norm_sqr(x) = norm(x)^2
Expand Down