NFC: some SSAIR pass improvements: #43221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
added
compiler:optimizer
aviatesk
force-pushed
the
avi/ssair
branch
2 times, most recently
from
1fdb661 to
706657c
Compare
- improve type stability around `perform_lifting!` - avoid using mutable `RefValue`s - add docstrings for `lift_comparison!` / `canonicalize_typeassert!` - fix `@nospecialize` annotation for `simple_walk_constraint`
DilumAluthge
removed
the
merge me
vtjnash
reviewed
Nov 26, 2021
|
|
||
| # Insert PhiNodes | ||
| lifted_phis = LiftedPhi[] | ||
| for item in visited_phinodes | ||
| # FIXME this cache retrieval is obviously broken |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
- improve type stability around `perform_lifting!` - avoid using mutable `RefValue`s - add docstrings for `lift_comparison!` / `canonicalize_typeassert!` - fix `@nospecialize` annotation for `simple_walk_constraint`
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
- improve type stability around `perform_lifting!` - avoid using mutable `RefValue`s - add docstrings for `lift_comparison!` / `canonicalize_typeassert!` - fix `@nospecialize` annotation for `simple_walk_constraint`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perform_lifting!RefValueslift_comparison!/canonicalize_typeassert!