-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 Bump the Downloads stdlib from a55825b to c445f45 #43430
🤖 Bump the Downloads stdlib from a55825b to c445f45 #43430
Conversation
Can this be backported to v1.7.2? would be really nice to get the threading fixes |
@StefanKarpinski I am assuming okay to backport? |
In general, we don't backport these bump PRs. Instead, you need to make a backport branch on the Downloads.jl repo, backport the desired PRs there, and then make a PR to the release-1.7 branch here. |
@StefanKarpinski If you can post the full instructions for how to do the backporting in Downloads.jl, then maybe @ericphanson can execute the steps? |
hm, I see. So Downloads v1.5 is associated to Julia v1.7, and Downloads v1.6 is associated to Julia v1.8? So I guess my question then is why bugfixes were given a minor release instead of a patch release (i.e. I'd rather they were in Downloads v1.5 😈). |
But we can remedy that by backporting the relevant bug fixes to a Downloads 1.5.x release. |
@ericphanson Want to make the backports PR? I believe you'd target this branch: https://github.com/JuliaLang/Downloads.jl/tree/release-1.5 |
Actually, I don't think it was a mistake. Like Julia, in Downloads.jl, PRs are always made against matter, and then backported as necessary. |
I just mean, this commit could've bumped the version to 1.5.2: JuliaLang/Downloads.jl@43899e7 -- no backports needed. Though I definitely might've missed something. |
I think the idea is that we want to always enforce the rule that we have different minor versions of Downloads.jl for different minor versions of Julia. |
Ok, I'll go ahead and make the backports if a Downloads.jl maintainer can confirm they would be accepted. |
If @StefanKarpinski can confirm that he's fine with the backports, I can do the logistical steps of merging your PR and registering a new release. |
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Stdlib: Downloads
URL: https://github.com/JuliaLang/Downloads.jl.git
Branch: master
Old commit: a55825b
New commit: c445f45
Bump invoked by: @StefanKarpinski
Powered by: BumpStdlibs.jl