Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Bump the Downloads stdlib from a55825b to c445f45 #43430

Merged

Conversation

DilumAluthgeBot
Copy link
Contributor

Stdlib: Downloads
URL: https://github.com/JuliaLang/Downloads.jl.git
Branch: master
Old commit: a55825b
New commit: c445f45
Bump invoked by: @StefanKarpinski
Powered by: BumpStdlibs.jl

$ git log --oneline a55825b..c445f45
c445f45 Merge pull request #170 from JuliaLang/tan/chunkedtransfer
4e0408a tests: use debug option to test for non/chunked uploads
911368d end-to-end tests for #167
55a0c39 add support for setting a debug callback
5bd0826 rename: singularize add_{upload,seek}_callback
ab628ab should also look into headers for input_size (#167)

@DilumAluthge DilumAluthge merged commit bf8b91d into JuliaLang:master Dec 15, 2021
@ericphanson
Copy link
Contributor

Can this be backported to v1.7.2? would be really nice to get the threading fixes

@DilumAluthgeBot DilumAluthgeBot deleted the BumpStdlibs/Downloads-c445f45 branch December 31, 2021 16:05
@vchuravy
Copy link
Member

vchuravy commented Jan 6, 2022

@StefanKarpinski I am assuming okay to backport?

@DilumAluthge
Copy link
Member

DilumAluthge commented Jan 6, 2022

In general, we don't backport these bump PRs. Instead, you need to make a backport branch on the Downloads.jl repo, backport the desired PRs there, and then make a PR to the release-1.7 branch here.

@DilumAluthge
Copy link
Member

@StefanKarpinski If you can post the full instructions for how to do the backporting in Downloads.jl, then maybe @ericphanson can execute the steps?

@ericphanson
Copy link
Contributor

hm, I see. So Downloads v1.5 is associated to Julia v1.7, and Downloads v1.6 is associated to Julia v1.8? So I guess my question then is why bugfixes were given a minor release instead of a patch release (i.e. I'd rather they were in Downloads v1.5 😈).

@DilumAluthge
Copy link
Member

DilumAluthge commented Jan 6, 2022

why bugfixes were given a minor release

That seems like a mistake.

But we can remedy that by backporting the relevant bug fixes to a Downloads 1.5.x release.

@DilumAluthge
Copy link
Member

@ericphanson Want to make the backports PR? I believe you'd target this branch: https://github.com/JuliaLang/Downloads.jl/tree/release-1.5

@DilumAluthge
Copy link
Member

why bugfixes were given a minor release

That seems like a mistake.

Actually, I don't think it was a mistake. Like Julia, in Downloads.jl, PRs are always made against matter, and then backported as necessary.

@ericphanson
Copy link
Contributor

Actually, I don't think it was a mistake. Like Julia, in Downloads.jl, PRs are always made against matter, and then backported as necessary.

I just mean, this commit could've bumped the version to 1.5.2: JuliaLang/Downloads.jl@43899e7 -- no backports needed. Though I definitely might've missed something.

@DilumAluthge
Copy link
Member

I think the idea is that we want to always enforce the rule that we have different minor versions of Downloads.jl for different minor versions of Julia.

@ericphanson
Copy link
Contributor

Ok, I'll go ahead and make the backports if a Downloads.jl maintainer can confirm they would be accepted.

@DilumAluthge
Copy link
Member

If @StefanKarpinski can confirm that he's fine with the backports, I can do the logistical steps of merging your PR and registering a new release.

LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants