Accelerate minimum(A; dims = 1)
for cartesian indexed cases.
#43618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
mapreduce
usemapreduce_impl
for linear-indexable inputs to accelerate min/max related calls, which is critical to Float cases especially when dim1 is included in reduction.But the optimization is missing for cartesian cases.
This PR try to fuse more
mapreduce_impl
for free speed:minimum
Benchmark (combined with #43604, which widen the optimizaiton to much shorten length):