Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base/version_git.sh: fix the default value for Base.GIT_VERSION_INFO (for e.g. when Git is not available) #43717

Merged
merged 2 commits into from
Jan 9, 2022
Merged

base/version_git.sh: fix the default value for Base.GIT_VERSION_INFO (for e.g. when Git is not available) #43717

merged 2 commits into from
Jan 9, 2022

Conversation

DilumAluthge
Copy link
Member

Fixes #43716

@DilumAluthge DilumAluthge added building Build system, or building Julia or its dependencies bugfix This change fixes an existing bug labels Jan 8, 2022
@DilumAluthge DilumAluthge changed the title Use Base.@kwdef to automatically provide a kwarg constructor for the GitVersionInfo struct with default values base/version_git.sh: provide a kwarg constructor (with default values) for the GitVersionInfo struct Jan 8, 2022
@DilumAluthge DilumAluthge changed the title base/version_git.sh: provide a kwarg constructor (with default values) for the GitVersionInfo struct base/version_git.sh: fix the default constructor for the GitVersionInfo struct Jan 8, 2022
@DilumAluthge DilumAluthge changed the title base/version_git.sh: fix the default constructor for the GitVersionInfo struct base/version_git.sh: fix the default value for Base.GIT_VERSION_INFO (for e.g. when Git is not available) Jan 8, 2022
@ngam
Copy link

ngam commented Jan 9, 2022 •
edited
Loading

@DilumAluthge + @mkitti thanks for this!

We are working on having a more robust packaging system downstream by doing regular dev releases to test breaking changes from "system packages" (see conda-forge/julia-feedstock#181) and this is quite helpful

@DilumAluthge DilumAluthge merged commit 709bc5c into master Jan 9, 2022
@DilumAluthge DilumAluthge deleted the dpa/git-version-info branch January 9, 2022 20:28
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@DilumAluthge @LilithHafner
base/version_git.sh: fix the default value for `Base.GIT_VERSION_IN…
71c6cb5 
…FO` (for e.g. when Git is not available) (JuliaLang#43717)

* `base/version_git.sh`: fix the default value for `Base.GIT_VERSION_INFO` (for e.g. when Git is not available)

* Use single-quotes to avoid the need to backslash-escape the double quotes
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@DilumAluthge @LilithHafner
base/version_git.sh: fix the default value for `Base.GIT_VERSION_IN…
b6c3dfb 
…FO` (for e.g. when Git is not available) (JuliaLang#43717)

* `base/version_git.sh`: fix the default value for `Base.GIT_VERSION_INFO` (for e.g. when Git is not available)

* Use single-quotes to avoid the need to backslash-escape the double quotes
@giordano giordano mentioned this pull request Apr 26, 2022
Open
@DilumAluthge DilumAluthge added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Apr 27, 2022
KristofferC pushed a commit that referenced this pull request May 16, 2022
@DilumAluthge
base/version_git.sh: fix the default value for `Base.GIT_VERSION_IN…
008432c 
…FO` (for e.g. when Git is not available) (#43717)

* `base/version_git.sh`: fix the default value for `Base.GIT_VERSION_INFO` (for e.g. when Git is not available)

* Use single-quotes to avoid the need to backslash-escape the double quotes

(cherry picked from commit 709bc5c)
@KristofferC KristofferC mentioned this pull request May 16, 2022
Merged
45 tasks
@t-bltg t-bltg mentioned this pull request May 23, 2022
Closed
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Jul 6, 2022
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@DilumAluthge
base/version_git.sh: fix the default value for `Base.GIT_VERSION_IN…
8668ea4 
…FO` (for e.g. when Git is not available) (#43717)

* `base/version_git.sh`: fix the default value for `Base.GIT_VERSION_INFO` (for e.g. when Git is not available)

* Use single-quotes to avoid the need to backslash-escape the double quotes

(cherry picked from commit 709bc5c)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@DilumAluthge @staticfloat
base/version_git.sh: fix the default value for `Base.GIT_VERSION_IN…
b4953f9 
…FO` (for e.g. when Git is not available) (#43717)

* `base/version_git.sh`: fix the default value for `Base.GIT_VERSION_INFO` (for e.g. when Git is not available)

* Use single-quotes to avoid the need to backslash-escape the double quotes

(cherry picked from commit 709bc5c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug building Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MethodError from base/version_git.sh
4 participants
@DilumAluthge @ngam @staticfloat @KristofferC