Remove debug information globals #43770
Conversation
pchintalapudi
added
compiler:codegen
|
Doesn't this need to get shared among all |
|
What happens if we create the debug information builders multiple times? Is it just a performance loss, or will LLVM silently break debuginfo? |
|
It shouldn't horribly fail, since the types don't have to agree, but will probably make unique types that are supposed to be the same. |
pchintalapudi
force-pushed
the
pc/debuginfo
branch
from
79101e1
to
321e677
Compare
src/aotcompile.cpp
Outdated
| @@ -453,11 +453,11 @@ void jl_dump_native_impl(void *native_code, | |||
| TheTriple.setOS(llvm::Triple::MacOSX); | |||
| #endif | |||
| std::unique_ptr<TargetMachine> TM( | |||
| jl_TargetMachine->getTarget().createTargetMachine( | |||
| jl_ExecutionEngine->getTargetMachine().getTarget().createTargetMachine( | |||
There was a problem hiding this comment.
this seems a little bit odd. Should we use a TargetMachineBuilder?
There was a problem hiding this comment.
We probably should, especially since we can choose to not expose the actual TargetMachine itself from the JIT engine.
There was a problem hiding this comment.
Update on this: my attempt at using a TargetMachineBuilder failed during building on macos, so I'm thinking it's better to revisit rewriting this particular sequence of instructions at a later date.
pchintalapudi
force-pushed
the
pc/debuginfo
branch
from
321e677
to
1c31d84
Compare
pchintalapudi
force-pushed
the
pc/debuginfo
branch
from
1c31d84
to
d34e739
Compare
pchintalapudi
force-pushed
the
pc/debuginfo
branch
from
d34e739
to
3057da1
Compare
Another PR in the line of removing the codegen globals.
Depends on #43802