Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debuginfo: Fix build on 32-bit ARM #44270

Merged
merged 1 commit into from
Feb 20, 2022
Merged

debuginfo: Fix build on 32-bit ARM #44270

merged 1 commit into from
Feb 20, 2022

Conversation

dnadlinger
Copy link
Member

This slipped through in 955d427, as we aren't building for
32 bit ARM during CI right now.

GitHub: Fixes #44254.

@dnadlinger
Copy link
Member Author

dnadlinger commented Feb 19, 2022 •
edited
Loading

NB: I couldn't actually test this change, as I don't have a suitable 32 bit ARM system at hand.

@giordano giordano added system:32-bit Affects only 32-bit systems system:arm ARMv7 and AArch64 labels Feb 19, 2022
@dnadlinger dnadlinger mentioned this pull request Feb 19, 2022
Merged
@giordano giordano added the backport 1.8 Change should be backported to release-1.8 label Feb 19, 2022
@giordano
Copy link
Contributor

https://dev.azure.com/JuliaPackaging/Yggdrasil/_build/results?buildId=17390&view=logs&j=33af64fb-1726-58c6-3bce-55667064c338&t=799645fc-6a09-525a-cab9-28f4aad7bd7d&l=2901

[20:49:18] /workspace/srcdir/julia/src/debuginfo.cpp:228:65: error: no match for call to '(std::function<long long unsigned int(const llvm::StringRef&)>) (llvm::Expected<llvm::StringRef>)'
[20:49:18]              uint64_t loadaddr = getLoadAddress(section.getName());
[20:49:18]                                                                  ^

@vchuravy vchuravy added this to the 1.8 milestone Feb 19, 2022
@dnadlinger
debuginfo: Fix build on 32-bit ARM
c9ac2ea 
This slipped through in 955d427, as we aren't building for
32 bit ARM during CI right now.

GitHub: Fixes JuliaLang#44254.
@giordano
Copy link
Contributor

32-bit ARM builds are now successful in JuliaPackaging/Yggdrasil#4461. Thanks!

@vchuravy vchuravy merged commit 6936433 into JuliaLang:master Feb 20, 2022
@dnadlinger dnadlinger deleted the debuginfo-fix-arm32 branch February 21, 2022 10:15
@KristofferC KristofferC mentioned this pull request Feb 23, 2022
Merged
33 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
system:arm ARMv7 and AArch64 system:32-bit Affects only 32-bit systems
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

Compile error on 32-bit ARM: debuginfo.cpp:228:33: error: 'L' was not declared in this scope
4 participants
@dnadlinger @giordano @vchuravy @KristofferC