-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of Dict{K,V}
(~5%) by storing elements in pairs::Vector{Pair{K,V}}
#44332
Closed
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
ae2aad5
Improve performance of 'Dict'
petvana 0acaa9a
Fix Set
petvana 8306858
Fix most of the tests
petvana 9a1a660
Use explicite types for pairs
petvana 82e7a9d
Mark broken test of precompilation
petvana 263dc86
Merge branch 'master' into pv-dict
petvana 96d80a5
Reenable broken test
petvana f37cc2d
Use simplified OldDict for testing precompilation
petvana 25d9bec
Fix precompile test
petvana 8d39aef
Fix white space
petvana 51a6c15
Merge branch 'master' into pv-dict
petvana 08d7d88
Apply suggestions from code review
petvana afd7975
Apply suggestions from code review
petvana e69826f
Fix performance of Set constructor if both {T,V} are bitstypes
petvana 6600b03
Apply suggestions from code review
petvana d789afc
Add inbounds
petvana cbe1cc7
Merge branch 'master' into pv-dict
petvana 326798e
Remove empty lines in test
petvana 2aee365
Merge branch 'master' into pv-dict
petvana 33b1133
Merge branch 'master' into pv-dict
petvana f9b27dc
Backward compatibility for keys and vals
petvana 406034b
Merge branch 'master' into pv-dict
petvana d093e7d
Improve backward compatibility
petvana 58414f8
Improve backward compatibility II
petvana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why all these type annotations here were added in the first place. They probably don't hurt, but I also don't see why they'd be needed.