Don't hash the key if dictionary is empty #44341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
changed the title
ht_keyindex if dictionary is empty
|
We can probably do one better, and check skip the hash for 1 element dictionaries as well (since there is only 1 place it can live) |
|
There is only 1 place, but where is that place? Related thought: I think it would be great to make Dict for less than a few elements actually just be semi-dense linear lists (roughly equivalent to defining hash(k)===1 if sz(d)<threshold). Only once it reaches a threshold would it start to use the real hashes. |
staticfloat
pushed a commit
to JuliaCI/julia-buildkite-testing
that referenced
this pull request
Mar 2, 2022
…ng#44341) Avoids hashing the input key for empty dictionaries. Inspired by rust-lang/hashbrown#305.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…ng#44341) Avoids hashing the input key for empty dictionaries. Inspired by rust-lang/hashbrown#305.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids hashing the input key for empty dictionaries.
Inspired by rust-lang/hashbrown#305.