Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dirpath.h #44412

Merged
merged 4 commits into from
Mar 14, 2022
Merged

Update dirpath.h #44412

merged 4 commits into from
Mar 14, 2022

Conversation

2005m
Copy link
Contributor

@2005m 2005m commented Mar 2, 2022

Follow up on PR #43986. Just Updating the code to avoid a warning like the one below on Windows + clang:

warning: 'JL_PATH_MAX' macro redefined [-Wmacro-redefined]

@vtjnash , @DilumAluthge, this should hopefully be a quick fix. Thank you.

@DilumAluthge DilumAluthge requested a review from vtjnash March 2, 2022 18:59
@DilumAluthge
Copy link
Member 

error: use of undeclared identifier 'MAX_PATH'

vtjnash
vtjnash reviewed Mar 2, 2022
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I was original code reviewer and clearly did not do a good job reading the code. I have made some suggestions that I think better align with the intent.

src/support/dirpath.h Outdated Show resolved Hide resolved
src/support/dirpath.h Show resolved Hide resolved
2005m and others added 2 commits March 2, 2022 22:41
@2005m @vtjnash
Update src/support/dirpath.h
dc6692f 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@2005m @vtjnash
Update src/support/dirpath.h
21ceea9 
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
@2005m
Copy link
Contributor Author

2005m commented Mar 3, 2022

Can we backport this PR to 1.8 please? Thank you

@fredrikekre fredrikekre added the backport 1.8 Change should be backported to release-1.8 label Mar 3, 2022
@KristofferC KristofferC mentioned this pull request Mar 4, 2022
Merged
47 tasks
@KristofferC KristofferC merged commit 529ac51 into JuliaLang:master Mar 14, 2022
KristofferC pushed a commit that referenced this pull request Mar 15, 2022
@2005m
avoid warning about macro redefinition on Windows + clang: (#44412)
b01c45c 
(cherry picked from commit 529ac51)
@KristofferC KristofferC mentioned this pull request Mar 15, 2022
Closed
14 tasks
KristofferC pushed a commit that referenced this pull request Mar 16, 2022
@2005m @KristofferC
avoid warning about macro redefinition on Windows + clang: (#44412)
484b622 
(cherry picked from commit 529ac51)
@KristofferC KristofferC mentioned this pull request Mar 18, 2022
Merged
17 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Mar 21, 2022
@LilithHafner LilithHafner mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

@gitboy16 gitboy16 gitboy16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@2005m @DilumAluthge @vtjnash @gitboy16 @KristofferC @fredrikekre