Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error msg test on 32-bit #44441

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

IanButterworth
Copy link
Member

Fixes a test failure introduced in #44319 on 32-bit

@oscardssmith oscardssmith added the bugfix This change fixes an existing bug label Mar 4, 2022
@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Mar 4, 2022
@oscardssmith
Copy link
Member

Is there a difference between Int and Int$(Sys.WORD_SIZE)

@DilumAluthge
Copy link
Member

Those should be the same.

@DilumAluthge
Copy link
Member

Ah, but when the error message is actually printed, it will be displayed as Int32 or Int64.

@DilumAluthge DilumAluthge merged commit 8c4ff55 into JuliaLang:master Mar 4, 2022
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Mar 4, 2022
@IanButterworth IanButterworth deleted the ib/err_32_fix branch March 4, 2022 04:34
@KristofferC KristofferC added the backport 1.8 Change should be backported to release-1.8 label Mar 14, 2022
KristofferC pushed a commit that referenced this pull request Mar 14, 2022
(cherry picked from commit 8c4ff55)
@timholy
Copy link
Member

timholy commented Mar 14, 2022

Usually the easiest is

julia> println("$Int")
Int64

@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants