Make SROA pass more aggressive #44494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
added a commit
that referenced
this pull request
Mar 7, 2022
With #44494, this cuts about 22M allocations (out of 59M) from the compiler benchmark in #44492. Without #44494, it still reduces the number of allocations, but not as much. This was originally optimized in 100666b, but the behavior of our compiler has changed to allow inling the Tuple{UseRef, Int} into the outer struct, forcing a reallocation on every iteration.
ianatol
pushed a commit
to ianatol/julia
that referenced
this pull request
Mar 15, 2022
With JuliaLang#44494, this cuts about 22M allocations (out of 59M) from the compiler benchmark in JuliaLang#44492. Without JuliaLang#44494, it still reduces the number of allocations, but not as much. This was originally optimized in 100666b, but the behavior of our compiler has changed to allow inling the Tuple{UseRef, Int} into the outer struct, forcing a reallocation on every iteration.
Keno
added a commit
that referenced
this pull request
Mar 15, 2022
With #44494, this cuts about 22M allocations (out of 59M) from the compiler benchmark in #44492. Without #44494, it still reduces the number of allocations, but not as much. This was originally optimized in 100666b, but the behavior of our compiler has changed to allow inling the Tuple{UseRef, Int} into the outer struct, forcing a reallocation on every iteration.
|
Merged as #44557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ianatol I think this one probably needs to go through PkgEval. It's pretty easy to end up in situations here where the use counts are off, which causes it to delete used statements. Could you take this one over, do PkgEval, add some tests, etc?