Fix code coverage in specific path mode #44625
Conversation
base/compiler/utilities.jl
Outdated
| m = moduleroot(m) | ||
| mpath = pathof(m) |
There was a problem hiding this comment.
Is this how we define the path for coverage? I thought it was managed per-line in the table by the caller
There was a problem hiding this comment.
I didn't think it was possible to be more specific in this function? Perhaps something other than this function is needed?
There was a problem hiding this comment.
I've tried to make coverage info emission file-based but I'm hitting a BoundsError, so it appears the index handling needs more thought
There was a problem hiding this comment.
I couldn't figure out doing it on a line by line basis, so now it's enabled for all lines in a CodeInfo if any of the lines fall in tracked files. Tests pass locally.
IanButterworth
force-pushed
the
ib/fix_code_cov
branch
2 times, most recently
from
36bbb59 to
82a316e
Compare
IanButterworth
force-pushed
the
ib/fix_code_cov
branch
from
82a316e to
8b999b7
Compare
|
This fixes the codecov tests, and running the Octavian tests locally with CI enabled take the same time as master, so seems to not have a noticeable performance hit. |
|
@vtjnash I'm planning to merge this tomorrow, just in case you have any review/objection before then |
|
Linux32 and win32 failures appear unrelated. The buildkite hang seems like a glitch? @DilumAluthge |
IanButterworth
changed the title
(cherry picked from commit feb7b77)
Fixes #44593