inference: follow up #44515, correctly encode Effects.overlayed effect

[aviatesk]

xref: #44515 (comment)

[giordano]

These functions are duplicates of

julia/src/staticdata.c

Lines 371 to 381 in c503611

	static void write_uint32(ios_t *s, uint32_t i) JL_NOTSAFEPOINT
	{
	ios_write(s, (char*)&i, 4);
	}
	static uint32_t read_uint32(ios_t *s) JL_NOTSAFEPOINT
	{
	uint32_t x = 0;
	ios_read(s, (char*)&x, 4);
	return x;
	}

Also, these function introduced a new warning when compiling julia: this header file is included by ircode.c which doesn't use these functions. I'm not even sure why there are functions implementations in a header.

[aviatesk]

What is the best way in C to define utility functions in a single place and import them from several places? In this case, dump.c uses all write_xxx utilities defined in serialize.h while ircode.c only uses some of them and so #include serialize.h produced that warning (and the same thing would happen for staticdata.c if we remove the duplications).

[giordano]

What is the best way in C to define utility functions in a single place and import them from several places?

Move the implementations (not the prototypes!) to a .c file, and make the files which need those functions depend on its corresponding object file in src/Makefile

[KristofferC]

Isn't the reason it is done like this to make the function definition available in all translation units and thus be eligible for inlining? But these functions are not marked inline though... But, to me, for consistency, the function in staticdata.c should be removed and this header included there instead?

[giordano]

#44739