Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inference: don't widen iskindtype-type to Type within tuple_tfunc #44896

Merged
merged 1 commit into from
Apr 11, 2022
Merged

inference: don't widen iskindtype-type to Type within tuple_tfunc #44896

merged 1 commit into from
Apr 11, 2022

Conversation

aviatesk
Copy link
Sponsor Member

@aviatesk aviatesk commented Apr 7, 2022

Follows up #44725.

@aviatesk aviatesk requested a review from vtjnash April 7, 2022 10:07
@aviatesk aviatesk mentioned this pull request Apr 7, 2022
Merged
@JeffBezanson JeffBezanson added the compiler:inference Type inference label Apr 7, 2022
vtjnash
vtjnash reviewed Apr 7, 2022
View reviewed changes
base/compiler/tfuncs.jl Outdated Show resolved Hide resolved
@aviatesk aviatesk changed the title inference: don't widen DataType/UninAll to Type within tuple_tfunc inference: don't widen iskindtype-type to Type within tuple_tfunc Apr 8, 2022
@aviatesk aviatesk force-pushed the avi/typetuple branch 2 times, most recently from 6dd7361 to fb36bc4 Compare April 10, 2022 21:28
@aviatesk aviatesk merged commit 0deb326 into master Apr 11, 2022
@aviatesk aviatesk deleted the avi/typetuple branch April 11, 2022 02:41
@vtjnash vtjnash added the backport 1.8 Change should be backported to release-1.8 label Jun 23, 2022
KristofferC pushed a commit that referenced this pull request Jul 4, 2022
@aviatesk
inference: don't widen DataType/UninAll to Type within `tuple_t…
50ceb7a 
…func` (#44896)

Follows up #44725.

(cherry picked from commit 0deb326)
KristofferC pushed a commit that referenced this pull request Jul 4, 2022
@aviatesk
inference: don't widen DataType/UninAll to Type within `tuple_t…
97c17e0 
…func` (#44896)

Follows up #44725.

(cherry picked from commit 0deb326)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
compiler:inference Type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aviatesk @vtjnash @JeffBezanson @KristofferC