Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly set Vboxed field during union codegen #44942

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Properly set Vboxed field during union codegen #44942

merged 1 commit into from
Apr 12, 2022

Conversation

ianatol
Copy link
Member

@ianatol ianatol commented Apr 11, 2022 •
edited
Loading

Fixes #44921

All credit to @vtjnash and @maleadt for the solution and test case respectively, all I did was package into this PR.

vtjnash
vtjnash reviewed Apr 11, 2022
View reviewed changes
test/compiler/codegen.jl Outdated
end
end
function g44921(a)
if !any([])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be any unknown condition, so might be simplest to make it _f also?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this code path is actually run, not sure how we can use _f here without getting an UndefVarError?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, true, would need to be something like !@isdefined _f

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See update

vtjnash
vtjnash approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing backport 1.6 Change should be backported to release-1.6 backport 1.7 backport 1.8 Change should be backported to release-1.8 and removed backport 1.7 labels Apr 11, 2022
@DilumAluthge
Copy link
Member

The Random failure on the x86_64-linux-gnu tester is #42752

The global RNG seed was 0x79104eec59565e99cd1b518b8970892.
 
Error in testset Test:
Test Failed at /cache/build/default-amdci5-7/julialang/julia-master/julia-72691483d9/share/julia/stdlib/v1.9/Test/test/runtests.jl:795
  Expression: orig == Random.default_rng()
   Evaluated: Xoshiro(0xb085b7d5b1c6a426, 0x7128c07ac362f37f, 0x86fa3d51e90d640c, 0x65b8e7a89ffd023f) == TaskLocalRNG()
Error in testset Test:
Test Failed at /cache/build/default-amdci5-7/julialang/julia-master/julia-72691483d9/share/julia/stdlib/v1.9/Test/test/runtests.jl:796
  Expression: rand(orig) == rand()
   Evaluated: 0.436257938130729 == 0.8544673546079519
ERROR: LoadError: Test run finished with errors

@DilumAluthge DilumAluthge merged commit 4c858f8 into JuliaLang:master Apr 12, 2022
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Apr 12, 2022
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@KristofferC
Fix 44921 by properly setting Vboxed field (#44942)
1f6dc03 
(cherry picked from commit 4c858f8)
@KristofferC KristofferC mentioned this pull request Apr 19, 2022
Merged
67 tasks
@KristofferC KristofferC mentioned this pull request May 16, 2022
Merged
45 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 26, 2022
@KristofferC KristofferC mentioned this pull request Jul 20, 2022
Closed
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
backport 1.6 Change should be backported to release-1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Illegal instruction crash on 1.7
4 participants
@ianatol @DilumAluthge @vtjnash @KristofferC